-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Document deprecation rationale for Artifact version constants #11584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Document deprecation rationale for Artifact version constants #11584
Conversation
|
Hi, just a gentle reminder. Whenever you get time, please take a look. |
|
Just checking in on this PR. It has been idle for a while and is still awaiting workflow approval and review. |
| * @deprecated since 4.0.0. | ||
| * The use of the {@code RELEASE} version is discouraged because it results | ||
| * in non-reproducible builds. | ||
| * Use an explicit version or a version range instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never use a version range foe the same reasons. Explicit versions only
| public interface Artifact extends Comparable<Artifact> { | ||
|
|
||
| /** | ||
| * @deprecated since 4.0.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need since 4.0.0.?
| * @deprecated since 4.0.0. | ||
| * The use of the {@code LATEST} version is discouraged because it results | ||
| * in non-reproducible builds. | ||
| * Use an explicit version or a version range instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds comprehensive JavaDoc documentation to explain the rationale for deprecating the RELEASE and LATEST version constants in the Maven Artifact interface. The constants were previously marked as deprecated in Maven 4.0.0, but lacked explanation.
Changes:
- Added detailed JavaDoc comments explaining that
RELEASEandLATESTversion constants lead to non-reproducible builds - Provided guidance to use explicit versions or version ranges instead
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary:
This pull request documents the rationale for deprecating the Artifact version
constants RELEASE and LATEST.
Why:
The RELEASE and LATEST version constants lead to non-reproducible builds and are
discouraged in Maven 4. This change makes the reason for deprecation explicit
and provides guidance on preferred alternatives.
What:
Scope:
Testing:
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.